fix: escape SQL LIKE wildcards in database helper search functions#210
Open
haosenwang1018 wants to merge 1 commit intoConway-Research:mainfrom
Open
fix: escape SQL LIKE wildcards in database helper search functions#210haosenwang1018 wants to merge 1 commit intoConway-Research:mainfrom
haosenwang1018 wants to merge 1 commit intoConway-Research:mainfrom
Conversation
The database-level search helpers (episodicSearch, semanticSearch, proceduralSearch) interpolate the query string directly into LIKE patterns without escaping % and _ characters. A query containing these characters alters the pattern semantics: "100%" matches every row, and "file_name" matches "fileBname". Escape %, _, and \ before interpolation and add ESCAPE '\' to each LIKE clause, consistent with the fix already applied to the memory manager classes. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
episodicSearch,semanticSearch, andproceduralSearchinsrc/state/database.tsinterpolate the query string directly into SQL LIKE patterns (%${query}%) without escaping%,_, or\characters%(e.g."100%") matches every row; a query containing_(e.g."file_name") matches unintended rows where_acts as a single-character wildcardEpisodicMemoryManager,SemanticMemoryManager,ProceduralMemoryManager), but the database-level helper functions were missedChanges
%,_, and\in the query before interpolating into LIKE patternsESCAPE '\'clause to all affected LIKE expressionsepisodicSearch(line 1403),semanticSearch(line 1470),proceduralSearch(line 1529)Test plan
database-search-wildcard.test.tscovering%and_escaping for all three search functions%in queries does not match all rows_in queries does not act as single-char wildcardtsc --noEmit)